Adrian

Results 569 comments of Adrian
trafficstars

You seem to have some weird data there - why does your data have `component` and `props`? Neither exist (nor should exist) in the data coming from the plugin.

You need to use `registerPluginObject`, not `registerPluginComponent`!

Are you still setting `icon` in your custom field definition? The warnings sounds like you don't... PS: Please share a link to the GitHub repo with your plugin. I'll gladly...

Yeah, I thought you might have commented it out while debugging the other problem. Anyway, Usually I check the code for this kind of problem to see what props there...

A few things that I noticed while skimming over it: - Indico plugin packages are usually named `indico_` (the distname in pyproject.toml is good though, `indico-plugin-` is the default) -...

Is it really necessary to change the APIs internally? At least what I had in mind was simply changing the logic in the emails module to determine how to use...

Just FYI, I plan to merge this end of next week, shortly before we're going to put this in production at CERN.

No, it's one of those "would be nice to have, but is not trivial and also adds a LOT of complexity" things...

I think the hardest part there is to create UI for configuring it. And doing estimates for UI work is pretty hard by itself.

Wouldn't it be easier to requier unique group name on KC? Allowing non-unique group names sounds like a complete mess TBH. In any case, how about using a separator that's...