Sternbach-Software

Results 120 comments of Sternbach-Software

Maybe with [this](https://stackoverflow.com/a/59102806/12528345) SO about cmp.equals() for structs?

Looks like [this](https://github.com/elliotchance/gedcom/blob/9061dcabbb6bdd35ed84163225bbb4737b2ba3ab/individual_node.go#L472) is the function (`func (node *IndividualNode) Similarity(other *IndividualNode, options SimilarityOptions) float64 {}`). Though, not sure if we want to mess with their similarity (because that is checking...

Tag.Is(Tag) is [here](https://github.com/elliotchance/gedcom/blob/master/tag.go#L810), but it doesn't look like that is used to exclude it from the diff.

Found where the code should go, in SimpleNode.Equals(). You may want to add a command line param to enable or disable this.

And how would you address the difference in which ancestry and Geni output dates? These two should be equivalent, not similar (I want to even keep matches that are 99.99%...

@elijulian Seems to cause bugs: https://github.com/KosherJava/zmanim/issues/198#issuecomment-1334082086

Then again, what are the use cases? Maybe the most common use case is calculating a zman for a given time zone, wrapping it in a zman, and displaying it...

True, but if it is >=,` Math.max` would be clearer.