zmanim icon indicating copy to clipboard operation
zmanim copied to clipboard

Published 20 hours ago • verified publisher icon KosherJava

Change README gradle import syntax

Open Sternbach-Software opened this issue 2 years ago • 5 comments

Replace implementation group: 'com.kosherjava', name: 'zmanim', version: '2.4.0' with implementation 'com.kosherjava:zmanim:2.4.0

Sternbach-Software avatar Nov 30 '22 16:11 Sternbach-Software

I think that this is a matter of taste, if you prefer this syntax maybe open a pull request to change it

elijulian avatar Nov 30 '22 18:11 elijulian

Definitely not a bug

elijulian avatar Nov 30 '22 19:11 elijulian

@elijulian Seems to cause bugs: https://github.com/KosherJava/zmanim/issues/198#issuecomment-1334082086

Sternbach-Software avatar Apr 23 '23 07:04 Sternbach-Software

Hi @elijulian it's not just a matter of taste in build.gradle.kts of KMM project (Kotlin Multiplatform Mobile), it doesn't compile. so this syntax is really needed: implementation("com.kosherjava:zmanim:2.5.0")

relevant PR: https://github.com/KosherJava/zmanim/pull/210

Screen Shot 2023-06-26 at 15 42 10

elfifo4 avatar Jun 26 '23 12:06 elfifo4

Hi @elijulian it's not just a matter of taste in build.gradle.kts of KMM project (Kotlin Multiplatform Mobile), it doesn't compile. so this syntax is really needed: implementation("com.kosherjava:zmanim:2.5.0")

relevant PR: #210

Screen Shot 2023-06-26 at 15 42 10

fascinating, i didn't realize that it was required by any platform.

elijulian avatar Jun 26 '23 14:06 elijulian