Sternbach-Software

Results 120 comments of Sternbach-Software
trafficstars

What would you like me to do? Merge your changes into my fork and then keep pushing on my fork? Or merge the changes on sternbach-translation into master (in your...

I really appreciate your effort!

I have finished translating the codebase (except the XML ids)! I pulled your changes to master into my master, and merged translate-code-to-english into my master.

I am resolving the conflicts now. I would like to discuss something: function naming. The Java convention is to name functions with a verb/action, not a noun. That means, for...

I suggested `F.exportGedcomToZip()` and you wrote `F.exportZippedGedcom()`. May we compromise on `F.exportGedcomAsZip()`? "exportZippedGedcom" implies that the gedcom is already zipped, and the function simply exports it. There is no implication...

Another point, from the [official guide](https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html) to writing Java documentation: > Use 3rd person (descriptive) not 2nd person (prescriptive). The description is in 3rd person declarative rather than 2nd person...

I will look into this. I don't believe the app currently uses Glide, which I believe would fix this issue as well as increase performance. Thank you for the logcat!...

I think you are thinking of [this](https://en.wikipedia.org/wiki/Glide_(API)). I am referring to [this](https://github.com/bumptech/glide) library. IIRC, it has solved similar issues in the past (4K images on low-spec devices that would crash...

If you are curios, see [here](https://developer.android.com/topic/performance/graphics/load-bitmap) about loading large bitmaps efficiently in Android.

Getting that stacktrace would be quite helpful. [This](https://github.com/michelesalvador/FamilyGem/blob/25141eebcdeea2e6b752489bfb55ba4580ed8c10/app/src/main/java/app/familygem/F.java#L237) is a dense function (assuming it is the code at fault).