SmallJoker

Results 322 comments of SmallJoker

Patches/suggestions are welcome. I don't really know how this mod works.

Might it be possible to add a few unittests to Minetest? That way we could be sure that the functions do indeed work as expected - before and after the...

1. Start the world 2. Read `map_meta.txt` as `Settings` object in Lua 3. Modify mapgen parameters as needed (make sure this only happens while there's no mapblocks generated yet) 4....

https://github.com/minetest/minetest/blob/504e43e0dae50ad98e19db0649c9c825cf2ab7a7/src/network/connection.cpp#L1454-L1459 https://github.com/minetest/minetest/blob/504e43e0dae50ad98e19db0649c9c825cf2ab7a7/src/network/connectionthreads.cpp#L265-L270 This uses the default connection timeout `CONNECTION_TIMEOUT` = 30 seconds which is summed up here: https://github.com/minetest/minetest/blob/504e43e0dae50ad98e19db0649c9c825cf2ab7a7/src/network/connection.cpp#L915-L926 And reset for each received package: https://github.com/minetest/minetest/blob/504e43e0dae50ad98e19db0649c9c825cf2ab7a7/src/network/connectionthreads.cpp#L962 If there is an issue,...

Looks good. Would you please be so nice to put your API description into a file instead of only mentioning it in the PR description?

*Not merging until the cache topic is resolved.* @SwissalpS As of now, the `"drawers_table_index"` metadata is only helpful when *inserting* items into the controller. It improves the lookup speed if...

Please provide reproduction steps. Cannot reproduce as of Luanti 5.13.0-dev (today's master build).

> may add more armor types Well, is there a mod that suffers from such issue? How many slots are needed? How should it be configurable? On a per-player basis...

Might a rapid double or triple sneak activation be a more intuitive way to use such feature? The setting could still stay to customize the amount of rapid sneak presses...