SmallJoker

Results 319 comments of SmallJoker

Areas depends on the `register_on_punchnode` callback, which is not run by pipeworks' `on_punch` callback. https://github.com/minetest/minetest/blob/6dcc9e63318f815a3de8c9db2ee7b845066e0135/doc/lua_api.txt#L7449-L7452 If this is an issue, please blame mods that do not run this callback -...

Well, I'd say that using all available space is the desired behaviour - as long it's guaranteed that no letters overshoot (handled already).

A FLOSS implementation of IEEE754 32-bit floats can be found here: https://github.com/minetest/minetest/blob/master/src/util/ieee_float.cpp (C++11, LGPL 2.1+) These conversion functions are compatible in memory-representation with the common implementation on x86_64 systems.

Needs rebase and review from @Calinou

I like this PR and was about to submit my review when I got an idea. Wouldn't it be more helpful to control these damage ticks with floats for each?...

I don't think there was much to fix up in the rebase but I think it's better safe than sorry, thus re-requested a review. Thank you.

> Question for core developers: The server does currently not have any media library dependencies (PNG, OGG), and I think that's OK for simplicity. Option 2 would IMO be the...

One more thought: Imagine 2 players. One with low latency (< 10 ms), another with more than a server tick. The high latency player will start the sound later and...