moreblocks icon indicating copy to clipboard operation
moreblocks copied to clipboard

Conserve left-over microblocks.

Open fozolo opened this issue 7 years ago • 5 comments

This commit conserves the microblocks so that they are never lost. Previously, any left-over microblocks were destroyed if the input box was manually emptied or if anything was taken from the output while the input box is empty.

fozolo avatar Jan 06 '18 07:01 fozolo

A code comment noted that this "covers material loss in the machine". However, this loss is applied inconsistently. For example, a player could add a single block to the input box and take out one microblock leaving 7 leftover. Then taking out one more microblock causes the remaining 6 leftover to be destroyed. Alternatively, the player could take out 8 microblocks at once. In the first scenario the player experiences 75% waste, while in the second scenario there is 0% waste.

fozolo avatar Jan 06 '18 07:01 fozolo

I don't know if it was a bug created by other mods or something alike, but it was just creating unknown items on the circular saw (that is what I remember). Used MT/MTG 0.4.17.1.

Panquesito7 avatar Aug 02 '19 00:08 Panquesito7

Needs rebase and review from @Calinou

SmallJoker avatar Mar 19 '20 21:03 SmallJoker

I read the code and the changes feel intuitive.

The4codeblocks avatar Jul 13 '23 14:07 The4codeblocks

I checked it and..... Events.

The4codeblocks avatar Jul 13 '23 16:07 The4codeblocks