Ryan Cavanaugh

Results 454 comments of Ryan Cavanaugh

@jcalz can you post a code sample so I can be sure I'm understanding the question?

The current rule for implicit index signatures is that the originating declaration must be an object type literal, or inferred from an actual object literal (let's call this "objectish"). IOW,...

This is a little tricky; TS sees the `x is NonNullable` as an opaque treatment of the type of `A`. As *humans* we know that if `x?.y?.z` isn't `undefined/null`, then...

This might be more tractable to fix now that `NonNullable` has a simpler definition

New to investigate: directus/directus puppeteer/puppeteer reduxjs/redux-devtools umijs/umi vercel/swr vuejs/core

`umi`'s error is correct. Isolated: ```ts const aliasLessImports = async ( ctx: string, alias: Record, importer: string, ) => { const importRegex = /@import(?:\s+\((.*)\))?\s+['"](.*)['"]/; const globalImportRegex = /@import(?:\s+\((.*)\))?\s+['"](.*)['"]/g; const match...

`directus` was impacted by the RegExp Match Array thing which we still need to pin down

`puppeteer` affected by a straightforward conflict in the node definition files

String spread is fine for ASCII stuff, but quickly goes off the rails for more complex characters. e.g. `[..."🤷‍♂️👴🏻"]` is `['🤷', '‍', '♂', '️', '👴', '🏻']`, `[...", ֶ, ִ, ֹ"]`...

Every type error we issue is a subjective call of what is and isn't a good idea in JS. There's no bright line anywhere.