Ryan Cavanaugh

Results 449 comments of Ryan Cavanaugh
trafficstars

> I'm worried that this approach breaks as soon as there is another package that also wants to extend the types. It's not really clear how to make this scenario...

Accepting PRs for this. Anyone interested? :smile:

> Additionally, this method doesn't capture the arguments of the constructor of the class (or its static members), This was a dealbreaker for us since it wouldn't even address the...

I don't understand what's going on in this thread. Need to take it back to the design meeting.

> This seems to be because the contextual type does not flow through to the argument provided to the generic function. The contextual type does flow through; proof: ```ts declare...

Contextual typing doesn't play into excess property checking (perhaps surprisingly)

```ts declare const identity: (x: T) => T; // Rename here renames alice but not bob type User = { name: string }; const a: User = { name: "alice"...

Depends what precisely you want to happen, but that seems like the right approach.

This seems fine to me but I'd really like one of the owners to ✔...