TypeScript icon indicating copy to clipboard operation
TypeScript copied to clipboard

[NewErrors] 4.9.0-dev.20221030 vs 4.8.4

Open typescript-bot opened this issue 3 years ago • 21 comments

The following errors were reported by 4.9.0-dev.20221030, but not by 4.8.4 Pipeline that generated this bug Logs for the pipeline run File that generated the pipeline

This run considered 200 popular TS repos from GH (after skipping the top 0).

Successfully analyzed 126 of 200 visited repos
Outcome Count
Detected interesting changes 17
Detected no interesting changes 109
Git clone failed 2
Package install failed 21
Project-graph error in old TS 3
Too many errors in old TS 44
Unknown failure 4

Investigation Status

Repo Errors Outcome
ant-design/ant-design 1
codex-team/editor.js 1
darkreader/darkreader 8
directus/directus 2
Eugeny/tabby 10
graphql/graphql-js 1
JedWatson/react-select 1
jupyterlab/jupyterlab 2
lensapp/lens 10
puppeteer/puppeteer 3
reduxjs/redux-devtools 1
reduxjs/reselect 2
Tencent/vConsole 6
umijs/umi 2
vercel/hyper 1
vercel/swr 3
vuejs/core 4

typescript-bot avatar Oct 30 '22 21:10 typescript-bot

ant-design/ant-design

tsconfig.json

  • error TS2352: Conversion of type '{ pagination: true; }' to type 'TableProps<any>' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

typescript-bot avatar Oct 30 '22 21:10 typescript-bot

codex-team/editor.js

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.build.json

typescript-bot avatar Oct 30 '22 21:10 typescript-bot

darkreader/darkreader

2 of 6 projects failed to build with the old tsc and were ignored

src/api/tsconfig.json

  • error TS2339: Property 'getRandomValues' does not exist on type 'never'.
  • error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'number'.

src/tsconfig.json

  • error TS2339: Property 'getRandomValues' does not exist on type 'never'.
  • error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'number'.

tests/inject/tsconfig.json

  • error TS2339: Property 'getRandomValues' does not exist on type 'never'.
  • error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'number'.

tests/unit/tsconfig.json

  • error TS2339: Property 'getRandomValues' does not exist on type 'never'.
  • error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'number'.

typescript-bot avatar Oct 30 '22 21:10 typescript-bot

directus/directus

4 of 15 projects failed to build with the old tsc and were ignored

packages/shared/tsconfig.json

tests-blackbox/tsconfig.json

typescript-bot avatar Oct 30 '22 21:10 typescript-bot

Eugeny/tabby

9 of 29 projects failed to build with the old tsc and were ignored

tabby-community-color-schemes/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-electron/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-linkifier/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-local/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-serial/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-ssh/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-telnet/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-terminal/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-terminal/tsconfig.typings.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

tabby-web-demo/tsconfig.json

  • error TS2352: Conversion of type 'MouseEvent & Record<"wheelDeltaY", unknown>' to type 'WheelEvent' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

typescript-bot avatar Oct 30 '22 21:10 typescript-bot

graphql/graphql-js

1 of 2 projects failed to build with the old tsc and were ignored

tsconfig.json

typescript-bot avatar Oct 30 '22 21:10 typescript-bot

JedWatson/react-select

3 of 5 projects failed to build with the old tsc and were ignored

packages/react-select/src/__tests__/tsconfig.json

typescript-bot avatar Oct 30 '22 21:10 typescript-bot

jupyterlab/jupyterlab

48 of 56 projects failed to build with the old tsc and were ignored

packages/services/examples/browser/tsconfig.json

  • error TS2403: Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; abort(reason?: any): AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; }'.

packages/services/examples/typescript-browser-with-output/tsconfig.json

  • error TS2403: Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; abort(reason?: any): AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; }'.

typescript-bot avatar Oct 30 '22 21:10 typescript-bot

lensapp/lens

6 of 8 projects failed to build with the old tsc and were ignored

tsconfig.json

webpack/tsconfig.json

typescript-bot avatar Oct 30 '22 21:10 typescript-bot

puppeteer/puppeteer

4 of 7 projects failed to build with the old tsc and were ignored

packages/testserver/tsconfig.json

  • error TS2403: Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; abort(reason?: any): AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; timeout(milliseconds: number): AbortSignal; }'.

test/installation/tsconfig.json

  • error TS2403: Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; abort(reason?: any): AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; timeout(milliseconds: number): AbortSignal; }'.

tools/tsconfig.json

  • error TS2403: Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; abort(reason?: any): AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; timeout(milliseconds: number): AbortSignal; }'.
    • file:///mnt/ts_downloads/puppeteer/node_modules/@types/node/globals.d.ts#L72 in tools/tsconfig.json

typescript-bot avatar Oct 30 '22 21:10 typescript-bot

reduxjs/redux-devtools

10 of 57 projects failed to build with the old tsc and were ignored

packages/redux-devtools-utils/tsconfig.json

  • error TS2367: This comparison appears to be unintentional because the types '{ immutable?: typeof Immutable | undefined; refs?: (new (data: any) => unknown)[] | null | undefined; replacer?: ((key: string, value: unknown) => unknown) | undefined; options?: unknown; }' and 'boolean' have no overlap.

typescript-bot avatar Oct 30 '22 21:10 typescript-bot

reduxjs/reselect

1 of 3 projects failed to build with the old tsc and were ignored

typescript_test/tsconfig.json

typescript-bot avatar Oct 30 '22 21:10 typescript-bot

Tencent/vConsole

tsconfig.json

  • error TS2741: Property '0' is missing in type 'string[]' but required in type 'RegExpMatchArray'.
  • error TS2339: Property 'apply' does not exist on type 'string extends keyof T ? T[keyof T & string] : any'.
  • error TS2322: Type '() => ReadableStreamReader<Uint8Array>' is not assignable to type '{ (options: { mode: "byob"; }): ReadableStreamBYOBReader; (): ReadableStreamDefaultReader<Uint8Array>; (options?: ReadableStreamGetReaderOptions): ReadableStreamReader<...>; }'.

tsconfig.type.json

  • error TS2741: Property '0' is missing in type 'string[]' but required in type 'RegExpMatchArray'.
  • error TS2339: Property 'apply' does not exist on type 'string extends keyof T ? T[keyof T & string] : any'.
  • error TS2322: Type '() => ReadableStreamReader<Uint8Array>' is not assignable to type '{ (options: { mode: "byob"; }): ReadableStreamBYOBReader; (): ReadableStreamDefaultReader<Uint8Array>; (options?: ReadableStreamGetReaderOptions): ReadableStreamReader<...>; }'.

typescript-bot avatar Oct 30 '22 21:10 typescript-bot

umijs/umi

18 of 48 projects failed to build with the old tsc and were ignored

packages/bundler-esbuild/tsconfig.json

tsconfig.json

typescript-bot avatar Oct 30 '22 21:10 typescript-bot

vercel/hyper

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

  • error TS2403: Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; abort(reason?: any): AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; timeout(milliseconds: number): AbortSignal; }'.
    • file:///mnt/ts_downloads/hyper/node_modules/@types/node/globals.d.ts#L72 in app/tsconfig.json

typescript-bot avatar Oct 30 '22 21:10 typescript-bot

vercel/swr

3 of 10 projects failed to build with the old tsc and were ignored

test/tsconfig.json

test/type/tsconfig.json

typescript-bot avatar Oct 30 '22 21:10 typescript-bot

vuejs/core

1 of 3 projects failed to build with the old tsc and were ignored

test-dts/tsconfig.json

tsconfig.json

typescript-bot avatar Oct 30 '22 21:10 typescript-bot

New to investigate:

directus/directus puppeteer/puppeteer reduxjs/redux-devtools umijs/umi vercel/swr vuejs/core

RyanCavanaugh avatar Nov 03 '22 19:11 RyanCavanaugh

umi's error is correct. Isolated:

const aliasLessImports = async (
  ctx: string,
  alias: Record<string, string>,
  importer: string,
) => {
  const importRegex = /@import(?:\s+\((.*)\))?\s+['"](.*)['"]/;
  const globalImportRegex = /@import(?:\s+\((.*)\))?\s+['"](.*)['"]/g;
  const match = ctx.match(globalImportRegex) || [];
  for (const el of match) {
    const [imp, _, filePath] = el.match(importRegex) || [];
    ctx = ctx.replace(imp, el.replace(filePath, "foo"));
  }
  return ctx;
};

imp may very well be undefined (as noted by the default to [])

RyanCavanaugh avatar Nov 03 '22 19:11 RyanCavanaugh

directus was impacted by the RegExp Match Array thing which we still need to pin down

RyanCavanaugh avatar Nov 03 '22 19:11 RyanCavanaugh

puppeteer affected by a straightforward conflict in the node definition files

RyanCavanaugh avatar Nov 03 '22 19:11 RyanCavanaugh