Ryan Cavanaugh

Results 447 comments of Ryan Cavanaugh
trafficstars

I want to take another look at this; seems like we might have the right machinery in place now

This isn't currently how narrowing works, but we could consider expanding its rules to cover this case

Not sure if "recursive" is the right word to apply to this situation. A discriminant property only applies to the object it's directly a member of. So in your example,...

I think this is a good fix; un-narrowing the source is going to make things more confusing. I can't commit the suggestion to the PR branch for some reason -...

🤔 Building TypeScript... TypeScript built successfully! git bisect good a71841c77bb42f9c691d2ae3572cd71ce48d4364 is the first bad commit commit a71841c77bb42f9c691d2ae3572cd71ce48d4364 Author: Mateusz Burzyński Date: Tue Jun 18 00:25:06 2024 +0200

I would say this is a correct result. From the compiler's POV, `Math.min` is no different from `Math.pow`, and it's inarguable that ```ts const smallestEnu = vals.reduce( (minEnu, val) =>...

We (I) need to categorize all the different use cases here - things invoked immediately, things sometimes invoked immediately, etc, and come up with a taxonomy of what callbacks do...

I don't even think this needs to be a setting. Going to `new Foo` should take you to `class Foo {` if it has an implicit constructor; from there you...