Ryan Cavanaugh comments

Results 449 comments of


                                            Ryan Cavanaugh

trafficstars

[BUG] This JSX tag requires the module path 'react/jsx-runtime' to exist, but none could be found. Make sure you have types for the appropriate package installed.

We need an actionable repro in order to investigate this A useful command if you have a lot of config files is the "Go to Project Configuration" verb in the...

Ban non-ambient modules written with `module` keyword

@typescript-bot test top800

Ban non-ambient modules written with `module` keyword

@typescript-bot test top800 @typescript-bot run dt

Ban non-ambient modules written with `module` keyword

gl-matrix builds index.d.ts from JS source (with `--module amd --outFile`!), but then patches out `declare module "sub" {` with `declare module sub {` with a [custom build script](https://github.com/toji/gl-matrix/blob/master/utils/bundle-dts.js#L31)

Add typings for path package

What's the upside of merging this, exactly? The node types already exist. This seems to just leave everyone worse off.

The output structures of `rootDir` and `rootDirs` are inconsistent

Confusingly, these settings are for basically completely unrelated behaviors, and are not expected to do the same thing. `rootDir` determines what base directory is used to compute the output path....

Unions without discriminant properties do not perform excess property checking

On review of this, it seems like the scenario in the OP isn't something we could feasibly touch at this point - it's been the behavior of EPC for unions...

Generic parameter type checking stops too early

This is tricky. By default this is done with a variance-based short circuiting; *not* doing this would be catastrophic to performance. Since it's only needed to probe the type deeper...

Generic parameter type checking stops too early

I'm not *endorsing* this as a great solution, but it works to get structural comparison as a fallback (thus preserving the perf benefits of variance measurement) ```ts declare const UnreliableSymbol:...

Predicate return type is lost when the predicate is passed as a parameter.

The way you're writing it, it could only work if generic calls were "stamped out" into concrete calls, but they're not. The body of `do_find` has to be analyzed only...