ProGamerGov

Results 515 comments of ProGamerGov

I just made the following changes, and now am working on changing the lowercase tensor to uppercase. * Converted all usages of the docstring types using `list of type` to...

@aobo-y Okay, I just converted all docstring type instances of `tensor` & `tensors` to `Tensor`!

@aobo-y I just noticed a new warning in the libmamba test. I thought it might be causing the Conda test to fail, but it still seems to be working though...

I added the `Tensor` intersphinx helper line to `autodoc_process_docstring` as we have previously discussed. I also checked each replacement instance to ensure that there were no issues.

@NarineK It worked on this PR, but I tried it on #985 and it's still running after 3 and half hours. Edit: It finally passed after just under 4 hours.

@NarineK That solution fails for nightly builds: ``` def versiontuple(v): return tuple(map(int, (v.split(".")))) output = versiontuple("1.12.0.dev20201109") print(output) ``` ``` --------------------------------------------------------------------------- ValueError Traceback (most recent call last) [](https://localhost:8080/#) in () 4...

@NarineK Is `captum/_utils/common.py` where we'd add the version parsing function? ``` from typing import Tuple, Optional def _parse_version(v: str, length: Optional[int] = 3) -> Tuple[int, int, int]: """ Parse version...

@NarineK I've implemented the `_parse_version` function and supporting tests.

@NarineK I just tested installing Captum & Matplotlib, and neither installed the packaging library. Its listed in Matplotlib's [setup.py](https://github.com/matplotlib/matplotlib/blob/main/setup.py), but not their [setupext.py](https://github.com/matplotlib/matplotlib/blob/main/setupext.py) (which I think is used for the...

@NarineK I've answered your question! The packaging library is downloaded as a dependency in the Captum dev install, but I'm not sure which package uses it as a dependency. So,...