ProGamerGov
ProGamerGov
@aobo-y Okay, I've removed it for this PR! Hopefully though there's some way around that issue that we can tackle in a future PR as its useful for simplifying function...
I'm seeing the additional tag used for the hyperlinks, but I am not seeing any wrong with the site. I don't see any signs that the site style is broken...
@aobo-y So, after tracing back the italics style issue, I found the source of Sphinx not properly handling `type1 of type2` cases in docstrings. I then worked with the Sphinx...
I've tested and compared the diffs between Sphinx v4.3.2 and v5.1.1, for the generated webpages. There is only one minor thing that needs to be addressed before we update the...
In https://github.com/pytorch/captum/pull/244, a bunch of of base functions were changed to class attributes in the `captum/attr/_utils/attribution.py` [file](https://github.com/pytorch/captum/blob/master/captum/attr/_utils/attribution.py). If subclasses don't overwrite these attributes, then Sphinx v5.x displays them in the...
I re-added the `autodoc_process_docstring` function for `Callable` & `Any`, only this time without the sphinx ref code. Instead it replaces `Callable` with `~typing.Callable` so that intersphinx hyperlinks it while preserving...
In addition to capitalizing `Callable` & `Any`, I think we should be capitalizing `Iterator`, `Iterable`, & `Generator` well. I also recently did one final sweep of the docstrings looking for...
PyTorch now officially has the same docstring type guidelines as the ones that I've created in this PR for Captum, now that my PR has been merged! https://github.com/pytorch/pytorch/pull/83536 https://github.com/pytorch/pytorch/blob/master/CONTRIBUTING.md#docstring-type-formatting
@NarineK @aobo-y This PR is ready for merging! Changes were made based on the reviewer feedback, and it would probably be best to merge this PR before other PRs end...
@aobo-y So in addition to what you listed, there are the following changes: * Add type hints to the `len` functions: `__len__(self) -> int:`, and to the `__getitem__` functions. *...