PikachuHy
PikachuHy
hi @comius > I'd suggest exposing a dict with 2 attributes from semantics, instead of 2 attr.labels. What we will do internally is put an empty dict there. There'a dict...
@comius @trybka ping
I apologize to @mathstuf for the mistake requested; I accidentally clicked the _Re-request review_ button due to a network issue.
hi @trybka , as https://github.com/bazelbuild/bazel/pull/22429#pullrequestreview-2258152911 mentioned, I checked the PR again and find one unresolved comment. I marked as resolved (see https://github.com/bazelbuild/bazel/pull/22427#discussion_r1730596288). please try import this patch again.
as https://github.com/bazelbuild/bazel/pull/19940#discussion_r1608064853 mentioned, I will remove remove the reuse of the .d file.
> @PikachuHyA Could you please take a look at the failing checks? This patch is dependent on the changes in https://github.com/bazelbuild/bazel/pull/22553. I will update this patch once that pull request...
I'm testing this patch. If this patch ready, I will remove the `[WIP]` prefix.
@comius @trybka please review this patch.
> Hey, this is quite a large PR and will take me some time to review it completely. Please also review https://github.com/bazelbuild/bazel/pull/22744, which contains a small patch split from this...
@comius kind ping