PikachuHy comments

Results 58 comments of


                                            PikachuHy

trafficstars

Deploy static content to Pages task is getting failure

it run success on https://github.com/alibaba/async_simple/commit/22b4336c6feb92fd2dbede778f6743b7f3b08fd0

[3/5] support C++20 Modules, add deps-scanner and update toolchains

I just keep the main commit in this patch. due to patch dependencies, it may build failed. I also fix `clang_deps_scanner_wrapper.sh.tpl` according to https://github.com/bazelbuild/bazel/pull/19940#discussion_r1608124067 and https://github.com/bazelbuild/bazel/pull/19940#discussion_r1608069861

[3/5] support C++20 Modules, add deps-scanner and update toolchains

hi @comius , the third patch is ready. please review.

[3/5] support C++20 Modules, add deps-scanner and update toolchains

> LGTM in general, except an a lot of renames to keep it consistent with PR[1/5]. > > Please replace cpp20_modules with cpp_modules. Please replace `deps_scanning` with `cpp_module_deps_scanning` - so...

[3/5] support C++20 Modules, add deps-scanner and update toolchains

@comius ping

[3/5] support C++20 Modules, add deps-scanner and update toolchains

@trybka ping

[3/5] support C++20 Modules, add deps-scanner and update toolchains

I'm testing https://github.com/bazelbuild/bazel/pull/22553 and find a bug in this patch due to https://github.com/bazelbuild/bazel/pull/22743 merged Changes - squash old commits to 1 commit - rebase to the latest master branch -...

[3/5] support C++20 Modules, add deps-scanner and update toolchains

@trybka ping

[1/5] support C++20 Modules, add module_interfaces attr

> You might want to consider a way to tell Bazel that some sources do not use modules and can therefore completely skip scanning (and, if nothing in the target...

[1/5] support C++20 Modules, add module_interfaces attr

hi @comius, I have updated the code. please review again. for each comment, I give a small commit. Squash commits can be performed if needed. I test the failed case...