PikachuHy

Results 58 comments of PikachuHy

hi @comius , thanks for your comments. I have updated the code. please review again. Changes Summary - update doc about `--experimental_cpp20_modules` option and `module_interfaces` attribute - refactor `_get_cpp20module_interfaces `...

> change the name from cpp20_modules to cpp_modules in the code Do I need to make this change in this patch?

hi @comius , I have updated this patch. please review again. In this patch, the tools `agg-ddi` and `gen-modmap` are added. These two tools replace old native action `Cpp20ModulesInfoAction` and...

hi @comius , please review again. Changes Summary - rename `agg-ddi` to `aggregate-ddi` - rename `gen-modmap` to `generate-modmap` - remove dependency `nlohmann_json` - implement a naive JSON parser, inspired by...

hi @mathstuf Due to the reimplementation with C++, the previous comments regarding the Java implementation can be ignored. If possible, please help review the C++ implementation. Let's automatically replace "Java...

as https://github.com/bazelbuild/bazel/pull/22429#issuecomment-2241727714 mentioned I'm testing https://github.com/bazelbuild/bazel/pull/22553 and find a bug in this patch Changes - rebase to the latest master branch - fix empty provides or requires The macOS CI...

hi @trybka > I expect we're going to want to put the tools behind semantics (in a similar fashion to grep-includes here). Regarding placing these tools under semantics, do you...

after rebase to the latest master branch, the CI passed.