Kate Lovett

Results 357 comments of Kate Lovett
trafficstars

So I've tested this manually against some of the regressions we saw in the past from trying to resolve this issue, so far all is well. :+1:

Still following up on tests, there is an infra issue with triggering and returning the results here

So there are some test failures, but they look to be expected. For example, if a customer has a screenshot test that scrolled before taking the picture, it would look...

Update: Still working with customers to ensure all of the changes we can see are expected for this PR. Almost there. 👍

Only 1 customer approval remains. Thanks for your patience.

> No; it turns out that DraggableScrollableSheet reimplements a fair bit of NestedScrollView logic. Ideally I think we should factor this logic away from DraggableScrollableSheet and generalize NestedScrollView, but I...

> Yes; let me know if you'd like them collected separately. If there are issues this PR resolves, they should certainly be documented and tested in the PR. :)

> Nothing immediate. This is working well for me locally, so filing issues for the edge cases with new tests in this PR and designing generalized scroll coordinators are not...

Yeah I am not sure what the issue is, there are a number of errors that have to do with unnamed library? ``` 01:00 +1000 ~1: /b/s/w/ir/x/w/flutter/packages/flutter/test/material/calendar_date_picker_test.dart: CalendarDatePicker Can select...