Kate Lovett

Results 357 comments of Kate Lovett
trafficstars

Found a case here where this is wrong, overlap should remain false until the min extent is reached in the case where maxExtent != minExtent. Will keep investigating.

Ok, I think this is correct for all cases now. I'll need to make a migration plan for affected customers. @thkim1011 do you want to try this in your main...

@HansMuller would you, mind checking this with your case as well (again)? There are so many permutations on persistent header, so the more the merrier to validate this.

Actually I found another case this does not agree with. Hold off on testing.

The Google tests are failing because #126679 has not rolled in yet. After it does we can rebase this and run the tests again.

@pdblasi-google are there any recent changes to the test package that could have caused this?

There are some affected customers here, one of them seeing a change in alignment with this change. Working with them now to update the code or find out if it...

I am working on migrating customers here. For now, can you hold off on pushing any commits? The Google tests throw out the old result when a new commit is...

In the meantime, I think a short migration guide in flutter/website is warranted here. When folks upgrade to this and the tab bar moves, it may not be easy to...

Thanks again for your patience here! I am still working through the customer tests. I found one case where it looks like the indicator and divider are not properly aligned...