Kate Lovett

Results 357 comments of Kate Lovett
trafficstars

If you are up for it, splitting this up further may help. There are hundreds of image tests and some of them are affected by the divider height change, some...

Ok, so for that specific test, it looks like the customer has a custom AppBar and a custom TabBar inside of that. But, it looks like this might be what...

Hmm, still trying to get a reproduction here. The fact that the customer is using a custom app bar and a custom tab bar is making it a bit difficult....

I have tried a bunch of different ways to try to repro the customer case, but have not been successful. I am waiting to hear back from them to see...

Thank you! I'll run this through and see if it still occurs. Much appreciated as always!

Good news! I checked the test results, the test failure we were trying to reproduce did not fail with the latest changes! 🎉 With that out of the way, I...

Update - all customers should be migrated now. I am rerunning the tests and will need to go through all the images again just to make sure there are no...

This is safe to land now, but the google testing shard is stuck. I filed a bug internally. Rebasing to see if that clears it up.

Hmm looks like we have some new test failures here

I think the behavior is more pronounced since https://github.com/flutter/flutter/pull/111250 IIRC, before then, it was possible for the mouse pointer to be separated from the thumb. Since that change, they are...