PastaPastaPasta
PastaPastaPasta
OS: Ubuntu 21.10 x86_64 Kernel: 5.13.0-22-generic gcc version 11.2.0 (Ubuntu 11.2.0-7ubuntu2) GNU ld (GNU Binutils for Ubuntu) 2.37
@AmineKhaldi were you able to replicate?
I was actually just beginning to work on a very similar PR, glad I saw this one before I got too into it. I would definitely propose merging this now,...
I would also like to see a release so I can use the `into_*` functions.
Win64 CI failure seems unrelated, would be nice if that could be restarted, or otherwise disregard the failure.
I've pushed 3 additional commits, removing inline where constexpr exists, and then I pushed a commit that adjusts begin() and end() as you suggested, although I think a better solution...
Any movement here? I know review time is precious, but I'd love to see this moved forward 🙈
> With such a nice modernization refactoring it seems reasonable to add `uint256.cpp` to the list of files being processed by the IWYU tool in the CI: > > ```diff...
Applied and squashed (and then rebased on master, as there was now a conflict) seeking re-ACKs @aureleoules @sipa
Sure, why not. Done and fped