PastaPastaPasta

Results 19 comments of PastaPastaPasta
trafficstars

Whoops 🙈 that's what happens when I forget to compile before pushing. Applied change, compiled, and force pushed :)

> I'm curios which part of C++ standard guaranties that the following comment is correct: > > https://github.com/bitcoin/bitcoin/blob/935acdcc79d1dc5ac04a83b92e5919ddbfa29329/src/uint256.h#L29-L30 > > ? > Will it result in indeterminate values of `uint8_t`...

[BIP78](https://github.com/bitcoin/bips/pull/923) was merged on the 25th of June

> I don't really see the point of using C++ style casts for integer types, as C-style casts are equivalent for those anyway. Yeah, if we could use C style...

Please see latest @sipa I have replaced non-narrowing static_casts (I introduced) with c++11 braced init instead

@sipa can you please review the current state of this PR? Thanks

Hi going through my old open PRs. Any chance we can get this merged?