Nir Azkiel
Nir Azkiel
> > @Nir-Az, No. This regex will fail in that case. > > Then please adjust @Arun-Prasad-V ?
@Arun-Prasad-V thanks for the fix. Do we know if it works? I mean if your are missing a year, will this fail? Hard to see from the UT log
@AviaAv always check if your test indeed run in all required OS. Hint: you are missing some definition on which device to run..
Please rebase development and run CI manually with nightly context and verify the test run and pass on all supported OS's
Thats a great solution! We will review it. Can you please undo unnessesary whitespaces and rebase for no conflicts? Thanks!
> Sorry for an extra commit after CI started. I tried to save one extra copy from happening 😅 NP, did you manage to verify that the intra process functionality...
According to the CI results The API was changed since `dashing`, we'll have to see what do we do about it.
> Apart from `foxy` and `humble`, other ROS 2 distros are [End of Life](https://docs.ros.org/en/humble/Releases.html). Do we still want CI to pass for those distros? > > If so I think...
> Apart from `foxy` and `humble`, other ROS 2 distros are [End of Life](https://docs.ros.org/en/humble/Releases.html). Do we still want CI to pass for those distros? > > If so I think...
Great! thanks a lot!