Jay Herron

icon indicating a website link https://www.herron.dev/

icon company PassiveLogic icon location Salt Lake City, UT icon location Lovingly crafting artisanal, small-batch, grass-fed software since 2015

Results 45 comments of Jay Herron

Top level fields in mutations should execute in SERIES not parallel

@cshadek Could you provide a more fleshed-out code example that displays the race conditions and unexpected results? I did some initial testing and was unable to create the data races/unexpected...

Is there a plan in place for adding support for async await?

@cshadek I have done a little thinking about subscriptions and async/await. The new [AsyncSequence](https://developer.apple.com/documentation/swift/asyncsequence) should be able to replace reactive drivers like [GraphQLRxSwift](https://github.com/GraphQLSwift/GraphQLRxSwift).

Is there a plan in place for adding support for async await?

@alobaili In the meantime, you can convert any `EventLoopFuture` API to an `async` one by using [`EventLoopFuture.get`](https://github.com/apple/swift-nio/blob/92d20d92b0cf8382ff889685abf6a88c91a4c9e7/Sources/NIOCore/AsyncAwaitSupport.swift#L24). For example: ```swift let result = await graphitiAPI.execute( request: request, ... ).get() ```

Is there a plan in place for adding support for async await?

Woah, I hadn't seen that repo before! That's pretty awesome stuff they're doing! Yeah, it seems like we could easily bring some of the extensions they've made into this repo.

Is there a plan in place for adding support for async await?

I have an [PR in to GraphQL](https://github.com/GraphQLSwift/GraphQL/pull/100) that adds async/await support, and a followup one ready for Graphiti once that one goes through.

Testflight

@adam-fowler With this change, should we remove the ubuntu items from [this line in the existing workflow yml](https://github.com/GraphQLSwift/GraphQL/blob/ebd2ea40676f8bcbdfd6088c408f3ed321c1a905/.github/workflows/build.yml#L16)?

Testflight

I've removed `Build and test on macos-10.15` and `Build and test on ubuntu-18.04` from the `master` branch protection rules

Testflight

Scratch that - I've changed the branch protection rules to be the actions that ran when this was merged to master. Specifically, the actions required are: - `Build and test...

Testflight

I agree with you Adam - requiring code owner approval seems sufficient to me. I'll let @paulofaria make the final call on this one though since he's been the primary...

Testflight

Awesome, I've removed the required status checks from GraphQL and aligned the projects throughout GraphQLSwift to have the same main branch protection settings. Thanks guys!