Jay Herron comments

Results 45 comments of


                                            Jay Herron

PostgresNIO/ListenStateMachine.swift:182: Fatal error: Invalid state: initialized

Oh good call - thanks for un-fixing. I totally agree that we ought to better protect against the fatalError case too.

Fix exception thrown when two classes with the same name (but not the same fully-qualified name) are registered in a Schema

Ah yeah, I've validated that this CI fails on main with the same error, so it doesn't appear to be related to your changes: https://github.com/GraphQLSwift/Graphiti/actions/runs/9586143166/job/26433471298?pr=138

Fix exception thrown when two classes with the same name (but not the same fully-qualified name) are registered in a Schema

OK, yeah you were exactly right on the v16 XCode version. We were using XCode `latest` (potentially unstable), which resulted in v16.0.0, whereas using `latest-stable` results in v15.4.0 and passes....

Fix exception thrown when two classes with the same name (but not the same fully-qualified name) are registered in a Schema

Alright the linked PR is merged. You should be good to rebase!

Fix exception thrown when two classes with the same name (but not the same fully-qualified name) are registered in a Schema

@abidon This change has been released in tag 1.15.1: https://github.com/GraphQLSwift/Graphiti/releases/tag/1.15.1