Micha Reiser comments

Results 761 comments of


                                            Micha Reiser

bench: Add JSON support to `xtask bench`

!bench_formatter

feat(rome_js_analyze): better JS suppressions

Requesting changes because: * It seems to me that the mutation adds the suppression comment as JSX Text for one of the test cases * `replace_token_transfer_trivia` doesn't seem to be...

feat(rome_json_formatter): Enable JSON formatting for debug builds

I created a `json` field on the settings.

fix(rome_js_analyze): false positives for `noUselessFragments` #3668

Would you mind giving this PR a more descriptive title. It's hard to guess what it is about from looking at the PR list or git log

fix(rome_js_analyze): fix noShoutyConstants with empty string

Thank you!

chore: Update rust-cache and add it to more jobs

!bench_formatter

chore(ci): centos7 ci container

Would you mind adding a description and test plan to your PR?

feat(rome_js_analyze): `useDefaultFunctionParameterLast`

> Due to the [decision of leops](https://github.com/rome/tools/pull/3908#issuecomment-1336995949), I will rename the rule to `useDefaultParameterLast`. The rule could be enhanced by handling generic parameters. Thanks for this comment. I was just...

`useLiteralKeys`

Naming. How about noComputedLiteralKeys (or MemberNames) or useLiteralKeys?

📎 Eslint rule compataibility/equivalency google sheet

Thank you for bringing this up and we agree. Having an easy way to discover what ESLint rules Rome supports today, will be supported in the near future, and we...