Micha Reiser

Results 749 comments of Micha Reiser

Thanks for updating the PR. Do you plan to refactor the code to use a `TypeContext` instead of extending the `ParserState`? There are a few tests failing that should pass...

> @MichaReiser > > Thank you for your reviews and i'm so sorry for a late response. I really appreciate the time you spent on this. I learned a lot...

> > There are a few tests failing that should pass > > I could fix these tests and pass all prettier tests! > > > Do you plan to...

That sounds good to me. Thank you @nissy-dev for another excellent parser contribution!

@jonas-w I think that's unrelated. I created a new issue to track the f-string format specifier handling.

This is an interesting question. I would expand the example by one that uses a non-section defining comment: ```python __all__ = [ "c", # TODO: Remove once #0000 is complete...

> That's an interesting idea! Let's call that Option (4). I worry with Option (4) that the precise semantics of the noqa directive might be hard for users to get...

> Here's an idea: as well as simple noqa comments to switch isort on and off, isort also supports slightly more sophisticated "action comments": [docs.astral.sh/ruff/linter/#action-comments](https://docs.astral.sh/ruff/linter/#action-comments). What if we had a...