tools icon indicating copy to clipboard operation
tools copied to clipboard

fix(rome_js_analyze): fix noShoutyConstants with empty string

Open rosslh opened this issue 3 years ago • 1 comments

Summary

Closes #3867

Test Plan

cargo test -p rome_js_analyze -- shouty

With some new test cases which were missing:

const Empty = "";
export const E = Empty;

const NotMatching = "DoesNotMatch";
export const F = NotMatching;

const matchingLowercase = "matchingLowercase";
export const G = matchingLowercase;

const AL = "ALPHA";
export const H = AL;

const ALPHA = "AL";
export const I = ALPHA;

rosslh avatar Nov 26 '22 16:11 rosslh

Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

Name Link
Latest commit 3218215326f53408a9806b914d0a8021be13037d
Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/638269adfe7bb40008800b29

netlify[bot] avatar Nov 26 '22 16:11 netlify[bot]

Thank you!

MichaReiser avatar Nov 28 '22 08:11 MichaReiser