GKlib
GKlib copied to clipboard
KarypisLab
Project modernization
This is the counterpart of https://github.com/KarypisLab/METIS/pull/79
I merged the development branch in master that have addressed some of those. If you have time and update the PR to reflect those changes, I'll be able to take a look at it this summer.
I can attempt to pull in the latest and see if the changes still work. There is the related https://github.com/KarypisLab/METIS/pull/79 branch that would really help out with Windows builds for METIS.
I was able to rebase and I would say the vast majority of changes are still necessary. As for the content of the code, I think there are some cmake improvements that could be made. Some of it is style choice, some of it is cmake best practices. Perhaps I could work with @LecrisUT on this, if they are willing.
Sure, I can give a re-review. I of course picked up a lot of design practices since this PR and there are aome minor details that I would change. The overall re-design is still there in order to make this be usable by other projects.
The only issue is if the maintainer is welcoming to these, then we can start suggesting piece-wise improvements. I can make a breakdown of the main changes that I would recommend and then address them in individual PRs
I think the interest is renewed, and if you rebase your fork locally and this branch, I can make some PRs toward it.
Piecewise improvements are likely not going to be possible as we're effectively re-writing the build system.
Looking at the changes made, I believe we can still do piecewise changes, e.g. chainging the CI, adding higher bound policy, etc. We should start over this one imo. I really urge @karypis to comment on the future plans for this project and maintenance. I would start with an issue reviewing the current state of master on what changes I would recommend (and the whys if requested)