Cristian Le

Results 898 comments of Cristian Le
trafficstars

> Could you actually stick to the above and simply specify the relative path to the directory? Directories are (namespace) packages, therefore importable modules, so I think you could just...

> `_ROOT` has extended behavior where it is propagated to any nested `find_dependency` or `find_package` call from the parent. That allows for a project that ship third party dependencies to...

Definitely should use either `_ROOT` or `CMAKE_PREFIX_PATH` given this info

I think we need to first start with how would the user use `CMakePackageConfigHelpers` macros. I can't envision right now if it would be an issue. What would the `site_packages`...

- test_valid_schemas_files[tests/packages/cmake_defines]: This one seems to be failing with the version of `pyproject-validate`. Our entry-point `validate_pyproject.tool_schema.scikit-build` should be using https://github.com/scikit-build/scikit-build-core/blob/3f371fff3d0dd424811ef73f58d88389263d79db/src/scikit_build_core/settings/skbuild_schema.py#L211-L216 to get the most recent version of the schemas that...

- Your library has dependencies, you should invert the order of from import and the ctypes load (but also try to avoid it altogether, there are better more native tools)...

> [@LecrisUT](https://github.com/LecrisUT) I don't fully follow your first point, I am not sure what other tools you mean, but otherwise you are saying the import order matters here. I was...

Ok, the full traceback helps, can you point to the codebase with that state?

That is my bad it seems that those are things that I forgot to remove from a different PR that I was working on (can't find that anymore 🤔) Curious...

@mmatous Some quick feedback from trying your contribution: - If a TypeAlias does not have a docstring written, it uses some generic docstring, probably inherited from somewhere else - When...