JoergAtGithub

Results 441 comments of JoergAtGithub

@upCASE Any chance to get this mapping finished for 2.3.0 ?

The problem is fixed for HID in: https://github.com/mixxxdj/mixxx/pull/4585 But syncing with the audio buffer wasn't the solution for HID, because all HIDAPIs IO commands are blocking and must all run...

This is Ready For Review, but depends on https://github.com/mixxxdj/mixxx/pull/4718. Therefore it's in state Draft.

I'm currently away from my computer and writing from my phone, I can't look for this until Tuesday. HidIoOutputReport::sendCachedData can only be called from the HidIO thread of the device....

I'm working on a solution. As a bandaid, please add wait times of ~20ms at lines 1998 and 2015 to your mapping.

> @JoergAtGithub I am unsure if double clicking of the `windows_buildenv.bat` still works. We have recently introduced a new environment variable MIXXX_VCPKG_ROOT for finding the vcpkg toolchain file. Can you...

> After restart, open cmd.exe and `echo %MIXXX_VCPKG_ROOT%` Double click the bat file, than open a new cmd.exe and `echo %MIXXX_VCPKG_ROOT%` again. This variable is not set! And I don't...

On the long term I suggest to switch from CMakeSettings to CMake-Presets: https://cmake.org/cmake/help/latest/manual/cmake-presets.7.html CMake-Presets can replace CMakeSettings in the IDE case, but can be used, by CommandLine CMake build too.

@Swiftb0y I addressed now all open review comments. I would be glad, if you could confirm, that I did this in your sense.

Yes, I fully understand this. Therefore I requested no re-review from you. But if you aggree, that my changes address your change requests, it would be nice, if you could...