JoergAtGithub
JoergAtGithub
Time to celebrate twice - the PR is exactly 1 year old today. 🎂
Thank you for the review!
@leifhelm I would like to start with the code review of the S2 Mk1 HID mapping. But before I start, I would like to hear, if you are still available...
- Mapping code looks good for me - A second user confirmed, that the mapping works for him too - Manual is in place Let's try what happens, if I...
@leifhelm Thank you for your contribution and your patience!
You merged main instead of 2.4 into this PR. I recommend hard reset to the previous state [5586005](https://github.com/mixxxdj/mixxx/pull/4834/commits/55860056d670091ec739500d5827fbdb7a00e386)
> Mhmm, the video you sent is a standalone controller though. Its not even related to Serato. Do they not mention this feature anywhere in their manual? The Numark NV...
Please change the target for this controller PR to 2.4.
I intend to delete the GitHub build action before merging. Only the changes in `CMakelists.txt` and the fixes of build error/warning should be merged.