JoergAtGithub
JoergAtGithub
> can someone also describe what i should fix according to the travis ci build? i dont get it :( > https://travis-ci.org/github/mixxxdj/mixxx/jobs/735567519 These are formatting issues. If you're on Linux,...
This happens often and has nothing to do with your code!
> should i just trigger a new compilation? By just pushing a empty commit? I don't think this is necessary, this happens so often, that every core team developer knows...
Merging in 2.3 only is Ok! Maybe you could replace the words "On Linux" by "With HIDAPI backend libusb".
> Real STEMs support as in Traktor would be fantastic, but isn't this PR is about an effect, which seperates one stem. For this limited use case the effect UI...
See https://github.com/mixxxdj/mixxx/pull/4760
> So what scope did you intend for this PR? No large changes, only cleanup and one small functional extension to initialize data.
Thanks for the feedback! I will address it! But some remarks go beyond the scope of this PR: -Except the class syntax, I changed this code only where it was...
> I fully understand that. It was not my intend to broaden the scope like that. > Let my explain my reasoning a bit: When you "modernize" code, only doing...