Ana Hobden

Seems to make sense to me :)

I think this is reasonable!

Maybe a `src/progress/benches.rs`?

The bones are in place for this if anyone would like to build on it. Feel free to ping us here and we can give you some guidance!

@ckousik I'd be really honoured. :) Is there anything I can help you with? You can examine our current benchmarking code and learn about [Criterion](https://bheisler.github.io/criterion.rs/book/index.html) to start.

Hi @ckousik, any way I can help with this?

@Fullstop000 Please!? 😍

Hmm... This is typically caused by one of these: https://github.com/tikv/raft-rs/blob/d34f6936e737563cc930bb8f03970a18f0cba7c9/src/progress/progress_set.rs#L301-L341 You can see when a node is removed from the `ProgressSet` we remove it from the `voter` set: https://github.com/tikv/raft-rs/blob/d34f6936e737563cc930bb8f03970a18f0cba7c9/src/progress/progress_set.rs#L347-L355 That's...

So some preliminary tests: * Online 1, Election (L1), Online 2 & 3, Pause, Down 2 or 3, no issues. Rejoin is fine. * Online 1, Election (L1), Online 2...

Seems this bit is what's important: ``` Nov 06 10:53:57.459 DEBG adding node (learner: false) with ID 3 to peers., id: 3, learner: false, raft_id: 2 Nov 06 10:53:57.460 DEBG...