raft-rs icon indicating copy to clipboard operation
raft-rs copied to clipboard

Published 20 hours ago • verified publisher icon tikv

Move benches into harness

Open Fullstop000 opened this issue 6 years ago • 3 comments

It seems that benches are unable to use harness based on the current project structure. How about moving the entire benches into harness? @nrc @Hoverbear

Now:

benches
harness
src

After:

harness
  benches
  src
  tests
src

Fullstop000 avatar Sep 10 '19 07:09 Fullstop000

I think this is reasonable!

Hoverbear avatar Sep 12 '19 18:09 Hoverbear

I find some benchmarks about ProgressSets use some internal APIs. Is it better to move those benchmarks to source code file? I guess it's helpful to clean our APIs.

hicqu avatar Nov 07 '19 11:11 hicqu

Maybe a src/progress/benches.rs?

Hoverbear avatar Nov 07 '19 16:11 Hoverbear