Ana Hobden

Results 385 comments of Ana Hobden
trafficstars

You're right! These things could definitely be improved.

Hi @Boscop ! :) `CopyGetters`, part of this was because if/when specialization ever lands we won't need it, and also because it was so heavily demanded. Using a distinct type/flag...

#49 has made usability considerably improved, is this still a request?

This is very interesting! I do worry this kind of API is outside the scope of this library (this focuses on *trivial* getters and setters, and these kinds of calls...

#49 may require us to rethink the proposed syntax here!

This seems to be a feature request, you're welcome to propose a syntax and work on a feature, but I don't use this crate, so it's unlikely I'm going to...

Sample output: ``` PS C:\Users\Hoverbear\Git\raft-rs> cargo bench Raft::cluster Compiling raft v0.6.0-alpha (C:\Users\Hoverbear\Git\raft-rs) Finished release [optimized] target(s) in 11.61s Running target\release\deps\raft-18f353cfeaa7c747.exe running 0 tests test result: ok. 0 passed; 0 failed;...

> Criterion complains about that benchmark time will be too long. Consider using raw benching. Is this the error? ``` Warning: Unable to complete 10 samples in 10.0s. You may...

Yeah, I think at this point we're mostly benchmarking channels and overheads of the benchmark itself. :( That is kind of the realistic case though, most raft clusters are running...

@Fullstop000 So you'd mock the non-leader actions?