Harald Leithner comments

Results 657 comments of


                                            Harald Leithner

[5.2] Refactor all instances of File::getExt() & stripExt() to use framework

No testing instructions, touches several places of the test is untestable, better make prs for the same area and not per type.

[5.2] Redesign carousel implementation to reflect documentation - bug fix

This pull request has been automatically rebased to 4.3-dev.

[5.2] Redesign carousel implementation to reflect documentation - bug fix

@Fedik @dgrammatiko I relabeled this a feature and moved it to 5.1 is this something we want and need?

[5.2] Redesign carousel implementation to reflect documentation - bug fix

This pull request has been automatically rebased to 5.2-dev.

[5.2] Minor cleanup for plugins JS

This pull request has been automatically rebased to 5.2-dev.

[5.2] CMSPlugin: deprecation for registerListeners

make sense for me

[5.2] Allow nested Subform inside a Subform Custom Field

Is an endless loop considered here? subform1 -> subform2 -> subform1 I don't think so, so maybe we should check for recursion at some point (rendering or saving)

[6.0] Admin modules code style

j4i this marks all layouts as changed on update

[6.0] Admin modules code style

This pull request has been automatically rebased to 5.2-dev.

[5.2] Usability: One Articles Module to Rule Them All

I would suggest not to write migration code and it's not really needed, we just don't ship mod_articles_* in the future (maybe directly starting with 5.2) and have a good...