[5.2] Redesign carousel implementation to reflect documentation - bug fix

[iteidrm]

Summary of Changes

This pull request fixes a bug in the Bootstrap Caraousel implementation of Joomla! (PHP and ES/JS) that causes valid parameters to be removed from the JavaScript options object that is fed to the Carousel instance.

Testing Instructions

I do not know if the Patch Tester extension will do the JavaScript re-build / pre-processing for you, and hope you know best what to do in this regard.

• Activate the debug mode in the global configuration to better be able to inspect the generated JavaScript option object in the source code (Browser: Ctrl + U).
• Install, activate and publish the demo module provided with the pull request on a module position of your choice (e.g. Cassiopeia: main-top). Make sure to set the Menu / Module Assignent to "On all pages".
• Open / refresh the page and change some params in the module manager (e.g. keyboard | wrap to false).

Actual result BEFORE applying this Pull Request

All options set to false are filtered out, causing the carousel to fall back to its default values.

Expected result AFTER applying this Pull Request

Params that can have a false value are recognised and work as expected.

Link to documentations

Please select:

• [X] Documentation link for docs.joomla.org: https://docs.joomla.org/J4.x:Using_Bootstrap_Components_in_Joomla_4#Carousel (slide vs ride)

• [ ] No documentation changes for docs.joomla.org needed

• [ ] Pull Request link for manual.joomla.org:

• [X] No documentation changes for manual.joomla.org needed

Demo Module

mod_bs_carousel.zip

[HLeithner]

This pull request has been automatically rebased to 4.3-dev.

[ceford]

I have tested this item :white_check_mark: successfully on 780d3d8a83f608e2e4236e8ceb16aac8084111db

Quite tricky to test - I had to edit in some of my own image links into the carousel because those supplied are broken. I can turn on each behaviour in turn and see that they work. I actually learned what some of the terms mean!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38930.}

[ceford]

To compile the js:

npm run build:js

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38930.}

[ceford]

Ah - I tested this against 5.0.0-beta2-dev

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38930.}

[HLeithner]

@Fedik @dgrammatiko I relabeled this a feature and moved it to 5.1 is this something we want and need?

[Fedik]

Looks fine, if it works :)

[dgrammatiko]

Ditto

[HLeithner]

This pull request has been automatically rebased to 5.2-dev.

[HLeithner]

This pull request has been automatically rebased to 5.3-dev.