Harald Leithner comments

Results 657 comments of


                                            Harald Leithner

[5.1] Multiload of article associations

This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from...

[5.1] Multiload of article associations

This pull request has been automatically rebased to 5.1-dev.

[5.1] Multiload of article associations

This pull request has been automatically rebased to 5.2-dev.

[5.2] $this: Cleanup of typehints for phpstan

Then we should disable the rule in phpstan, is there an issue to check at phpstan for this feature?

[5.1] com_users: Simplifying empty check in login layout

interesting your change changes the behavior more then I expected: https://3v4l.org/7LM6I (yours is $z)

[5.1] com_users: Simplifying empty check in login layout

my suggestion is to move it to `!empty(trim($value))`

[5.1] com_users: Simplifying empty check in login layout

This pull request has been automatically rebased to 5.1-dev.

[5.1] com_users: Simplifying empty check in login layout

This pull request has been automatically rebased to 5.2-dev.

[5.2] Refactor all instances of File::makesafe() to use framework

missing test instructions, you change the template and the media manager plugins and more at the same time.

[5.2] Delete user access level - check for levels in use

This pull request has been automatically rebased to 5.2-dev.