[5.2] $this: Cleanup of typehints for phpstan

[Hackwar]

Summary of Changes

When typehinting $this in our layouts, we use both the full qualified name and a shortened version with an import. phpstan unfortunately does not currently understand the version with the import and thus this unifies this to the long version.

Testing Instructions

Codereview

Link to documentations

Please select:

• [ ] Documentation link for docs.joomla.org:

• [X] No documentation changes for docs.joomla.org needed

• [ ] Pull Request link for manual.joomla.org:

• [X] No documentation changes for manual.joomla.org needed

[HLeithner]

Then we should disable the rule in phpstan, is there an issue to check at phpstan for this feature?

[brianteeman]

Then we should disable the rule in phpstan, is there an issue to check at phpstan for this feature?

exactly

[Hackwar]

https://github.com/phpstan/phpstan/issues/10936

[Bodge-IT]

Issue deferred to PHPStan, change not required in Joomla. Thanks Hannes.

[laoneo]

Is this excluded in our PHPStan setup?

[Hackwar]

no, it isn't.