Michael Brevard

Results 98 comments of Michael Brevard
trafficstars

Still need to figure out why the dev builds fail... It doesn't make much sense that https://github.com/nuxt/nuxt/pull/25771/commits/44d3c193ac85a2a0f004651f71f090ab9d5d952d caused the 8 dev builds to fail for the first time, it just...

Update: I decided to rework this more carefully, I will open a new PR for it and close this one.

@danielroe The failing tests don't really have anything to do with the PR... I haven't changed anything in the component island URL's. Is this something I accidentally did with one...

Sorry this took so long, personal life has been very demanding! I would like to hear your opinion on whether this PR should be an "mono-perf PR" and kept around...

Thanks for the refactor! I had planned to do it but got a bit caught up with something, sorry about that 😅 Although I do wonder why with reduce 2...

May I ask why the revert? I get that smaller arrays would provide less of a performance improvement, but it's an improvement nonetheless. If anything, we can further improve performance...

Well, in that case I suppose it's reasonable. Thanks for the feedback!

> Good spot :) I'm also personally a fan of placing non-negated expressions in the `if ()` condition first and using `else` for the negated version of it (for improved...

![image](https://github.com/nuxt/nuxt/assets/92037085/b18dd947-6fa1-4dab-bd7e-b9bc9b978725) Appears to be a bit mixed with the current method being sometimes faster, but I do agree that for the initial installation it would make a difference Also, due...