Michael Brevard

Results 109 comments of Michael Brevard
trafficstars

Thanks for linking! This could likely simplify it a lot, but there are still things I would like to test. Specifically, more customization for visibility/idle based approaches and how it...

@danielroe I'm linking here this PR https://github.com/vuejs/core/pull/11530 that took care of the full customization options for delayed hydration strategies. Should I rework this ahead of time to use the expected...

@danielroe should I wait with changing the presets and tests that you made in your refactor and then pull it once it's merged, or should I change them?

A topic for discussion could be supporting async/promise conditions in conditional hydration. I don't imagine there are many use cases for that but I could probably add support for it...

The failing test fixture appears to be related to some intermittent fetch issue, updating branch would likely resolve it.

The link checker was broken from even before then, I was referencing [test-fixtures (windows-latest, dev, vite, default, manifest-on, json, 18)](https://github.com/nuxt/nuxt/actions/runs/10861880723/job/30144306768#logs)

Reverting to draft because there is an issue with reactivity that I need to fix Update: this has been fixed

@vejja thanks for the explanation! This really does help a lot, and will be very useful for the PR. Does that mean no further modification needs to be made for...

> I think if you can get rid of 02a and 99b, it would be fantastic. Honestly they are a legacy of trying to quick-fix the cheerio issues 👍 I...

If I am correct (I haven't worked much with nitro's HTML hooks myself), the bodyAppend/prepend/etc return strings, right? They just return the stringified HTML? Because I see a `$('script')` inside...