Ben Durrant

Results 150 comments of Ben Durrant

other previously suggested rules: - no spreading `...getDefaultMiddleware()` - no `state = foo` inside immer reducers

a no no-op selector lint rule seems a little less necessary now it's checked in runtime, but i suppose it would be nice to be done with static code analysis...

we'd probably want to put reselect related rules under the same plugin as well - we can always offer a "reselect-only" config some community-made packages we may want to see...

another thing to possibly catch: ```ts const middleware: Middleware => api => next => async (action) => {} ``` the final function for a middleware should never use the async...

based on https://phryneas.de/redux-typescript-no-discriminating-union - a lint rule that prevents dispatches without an action creator

probably the same - the splitAddedUpdatedEntities only checks if they're in the *current* state, not the state after each update has been applied all of the entries get counted as...

Generally quite confused by this discussion. > At first glance, that sounds like normal Redux behavior. > > If you look at the Redux core inside of dispatch(), it does:...

Website builds locally, I have no visibility on what's upsetting Vercel 🤔

Weird, it definitely works with bows for me, so it'd suggest the predicates are not the issue.