Ben Durrant

Results 146 comments of Ben Durrant

just preference really - i like having the transformation contained in the schema, rather than having to do it separately before feeding it in similar to the json methods from...

> This might be the obvious answer I am not sure if there's a clear reason why BigInt was not handled in the first place or not > Alternatively there...

It's not nullable, it's optional, because you didn't mark it as required: https://swagger.io/docs/specification/v3_0/data-models/data-types/#objects

personally i would be against reselect including some sort of one-size-fits-all solution - `fn.length` is not reliable because of rest and defaulted parameters. (for example, `createSelector(...).length` is always 0) in...

It already does, that's the first intersection you're seeing. https://github.com/reduxjs/redux-toolkit/blob/af3e75bb9e6a51e13603d2a5684ef3ba1da07e3b/packages/toolkit/src/createAsyncThunk.ts#L239 `Promise & SafePromiseBrand & ExtraMethods`

why are you creating multiple listener middleware instances, instead of registering all of your listeners to one instance?

> > Tiny thing, but the current code is creating a new `isAnyOf` matcher instance for every dispatched action, which isn't necessary. ` > > [@markerikson](https://github.com/markerikson) Thanks for the suggestion!...

> > For that matter, I'd also suggest changing any of the conditional listeners / middleware to only add them in the environments where they actually matter. For example, there's...

in general, *any* next state that's calculated based on a previous state belongs in the reducers. that's the only way to guarantee that it updates correctly, similar to using a...

I can't replicate this in the [playground](https://tsplay.dev/mZd6aw) - does this happen when you run TSC, or just in your IDE? Which IDE are you using?