Ben Durrant

Results 147 comments of Ben Durrant

config first seems more consistent with the codebase

little conflicted, but I think the consistency and futureproofing is worth the increase in verbosity - i don't know how many people would actually need to use the reviver anyway.

> Thank you! If I understand correctly, the cache only works for primitive values or complex values with the same reference. Providing a new object as the `dataset.value` would result...

yeah, this is a [2.0 change](https://redux-toolkit.js.org/usage/migrating-rtk-2#rtk-query-behaviour-changes) - you can set `invalidationBehavior: 'immediate'` to use the 1.9 behaviour.

it's a runtime problem - in the vast majority of cases we do not have the initial type (and until recently it was impossible) so we should just expect the...

I'm pretty sure the error message is dependent on your environment since it's thrown directly by JSON.parse. I'd be tempted to just `expect.stringContaining("SyntaxError")` it to be honest.

is it worth making a configurable version of createDraftSafeSelector too? that currently uses immer's isDraft() and current()

I think the CI failures have been putting people off - I'll try rebasing the PR to see if the CI failures still happen.

yes - i rebased https://github.com/reduxjs/redux-toolkit/pull/4864 today and its CI is passing fine.

This appears to be intentional behaviour - `useQuery` holds onto the last successful request's `data`, and `isSuccess` is true if it has data and is currently fetching. I don't fully...