Dipto Chakrabarty

Results 88 comments of Dipto Chakrabarty
trafficstars

hey since this is solving the issue of #940 deleting resources using yaml maintainers can this be merged pleased

> it is mostly duplicates from create_from_yaml, better to refactor it into a common file, then have create_from_yaml, and delete_from_yaml share the common util. Can this not be a new...

> @DiptoChakrabarty -- I agree with @yliaog. It's better to address the duplication of logic in this PR itself. I wouldn't say that deduplication of logic is a new enhancement....

I made a new file operate_from_yaml which has both the create and delete features as requested. Please tell me if I have to add anything more in it.

Hey @reviewers can you please review this and tell what I have to do next or any suggestions

Hey I have rebased it again , @reviewers please review it I have implemented all changes that had been mentioned .

@reviewers can this be reviewed before the next merge please or else create_from_yaml will constantly get updated and the changes proposed by this PR will become delayed and outdated pushing...

@yliaog can we do another round of review please.I would like to move this PR forward.Thank You.

![image](https://user-images.githubusercontent.com/45638240/129482843-b53cc93b-8d2c-43dc-9f76-364187a678b1.png) hey I think the tests are passing with the recent commit.