python
python copied to clipboard
kubernetes-client
Delete kubernetes resources from yaml files , solves #940
This is a method to delete kubernetes resources using the yaml files . It is similar to the method create_from_yaml but for deleting kubernetes resources . It can be used to any type pf resource deployment , pod , service etc. Fixes #940
create_from_yaml creates kubernetes objects like deployments,serivces,ingress etc from the given yml files , the delete_from_yaml method can be used to remove/delete those objects from the same yml files in the given cluster for any namespace
hey all the tests are passing for my branch in my repo
However in the master branch the test_portforward_raw.py test seems to be failing only causing the travis build to fail , I havent done any changes to that file
What can I do since I havent edited that file
test_portforward_raw is flaky, we have an issue to track fixing it.
closing to trigger CI /close
@yliaog: Closed this PR.
In response to this:
test_portforward_raw is flaky, we have an issue to track fixing it.
closing to trigger CI /close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@yliaog: Reopened this PR.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: DiptoChakrabarty To complete the pull request process, please ask for approval from yliaog after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
hey since this is solving the issue of #940 deleting resources using yaml maintainers can this be merged pleased
it is mostly duplicates from create_from_yaml, better to refactor it into a common file, then have create_from_yaml, and delete_from_yaml share the common util.
it is mostly duplicates from create_from_yaml, better to refactor it into a common file, then have create_from_yaml, and delete_from_yaml share the common util.
Can this not be a new issue as this PR is solving the issue of deleting using yamls feature and a common file would be a new enhancement
@DiptoChakrabarty -- I agree with @yliaog. It's better to address the duplication of logic in this PR itself. I wouldn't say that deduplication of logic is a new enhancement.
@DiptoChakrabarty -- I agree with @yliaog. It's better to address the duplication of logic in this PR itself. I wouldn't say that deduplication of logic is a new enhancement.
Okay I am working on it
I made a new file operate_from_yaml which has both the create and delete features as requested. Please tell me if I have to add anything more in it.
Hey @reviewers can you please review this and tell what I have to do next or any suggestions
Hey I have rebased it again , @reviewers please review it I have implemented all changes that had been mentioned .
@reviewers can this be reviewed before the next merge please or else create_from_yaml will constantly get updated and the changes proposed by this PR will become delayed and outdated pushing it further back since it depends on it.
@yliaog can we do another round of review please.I would like to move this PR forward.Thank You.
yes, it will be helpful to squash the commits.
I'm very busy lately, @palnabarun do you have time to review the PR?
yes, it will be helpful to squash the commits.
I'm very busy lately, @palnabarun do you have time to review the PR?
Yes Squashed it
I have re based the recent changes and the tests are passing in my branch , can this PR be reviewed please. Thank You.
@DiptoChakrabarty: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.