Dipto Chakrabarty
Dipto Chakrabarty
@Ankitasw based on the change I should add a test to check `Subnet != asg.Subnet` right ?
> Is this change yet to be done? yes , added the testcase but encountering an error , will push the test soon
the tests are failing because I set the `machinePoolScope.AWSMachinePool.Spec.Subnets` as `[]infrav1.AWSResourceReference{ { ID: pointer.String("subnet1"), }, { ID: pointer.String("subnet2"), }, },` and the `existingASG.Subnets` as `[]string{"subnet1", "subnet2"},` do they have to...
> I am not sure how cmp.Equal will work with different types of structs. @shivi28 I remember you making a doc on go cmp usage, can you let us know...
@sedefsavas so in here https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/6ab95625da2aabb209bc5744883eb4c009cc4fba/exp/controllers/awsmachinepool_controller.go#L534 I create a `autoscaling.Group (from github.com/aws/aws-sdk-go/service/autoscaling)` using the `*scope.MachinePoolScope` and fit that into SDKToAutoScalingGroup which returns a `expinfrav1.AutoScalingGroup` and compare it to `existingASG *expinfrav1.AutoScalingGroup (value...
@sedefsavas made a PR , just a bit confused on the comparison/diff checking between `existingASG` and `machinePoolScope.AWSMachinePool.Spec.Subnets` , will follow up any changes requested. Thank you for all the help...
> @DiptoChakrabarty are you able to bring tilt up with this PR as is? I'm getting a number of errors when trying to run this change. Yes I had a...
@sbueringer I removed them from tiltfile , however I was getting another error ```tiltbuild/yaml/clusterctl.crd.yaml: no such file or directory , .tiltbuild/yaml/docker.provider.yaml: no such file or directory , .tiltbuild/yaml/core.provider.yaml: no such...
> `tiltbuild/yaml/clusterctl.crd.yaml: no such file or directory , .tiltbuild/yaml/docker.provider.yaml: no such file or directory , .tiltbuild/yaml/core.provider.yaml: no such file or directory` I am still getting this above error while running...