Dimitar Krastev

IMO, having the `checkMtu` as public and `doMtuCheck` possibly deprecated/removed would be better? None of the other public methods have the naming structure of `doMtuCheck`, so it kinda sticks out...

Although on second thought, perhaps `checkMtu` is a bit ambiguous as it might be interpreted as a check for the MTU instead of against the MTU. Perhaps changing the method...

@seladb Changed the function name to be more explicit and moved the new functions to public API. Also added a new section to the PR post explaining how the change...

@seladb IDK, about the previous internal logic being clear. I spent a significant amount of time trying to wrap my head around the original call chains of `sendPacket` initially, due...

@seladb moved the declarations to protected, or do you want them explicitly in private?

Haven't looked at it in depth, but a way I can see it implemented in the framework can be something like this: - A main `ModbusLayer` that parses the frame...

@seladb Imo, a composition approach would be better than an inheritance one here, as there are a lot of PDU functions and the potential for people wanting to define their...

@seladb Here is an example. ```cpp auto modbusLayer = modbusPacket.getLayerOfType(); // get the common header fields modbusLayer->getTransactionId(); modbusLayer->getLength(); auto fnCode = modbusLayer->getPDUFunctionCode(); // Parses only the first byte of the...

@yahyayozo yes, `PDUType` is a placeholder for a public PDU struct. Here is an example implementation using the ReadCoils public function code. For simplicity the example ignores endianness. ```cpp class...

@yahyayozo The first approach is preferred, but its up to you. You can open a PR to the dev branch in draft mode while you are working. That way you...