Dimitar Krastev

Results 63 comments of Dimitar Krastev
trafficstars

Update on the memory leak infrastructure: It still doesn't work directly on global level as gtest uses thread local variables that end up lazy initializing at runtime, but get released...

> Not sure if I fully understood. Aren't all tests passed now? Tests pass because the memleak is disabled in the gtest project currently. [[1]](https://github.com/seladb/PcapPlusPlus/pull/1507/files#diff-b200b92ca48807fec6d8612efdafed6e1f786ecc093b90f8bdc72728027bdfd3R31-R35)

@tigercosmos In my tests, it didn't work having the memory tracking encompass all the tests as a single start/stop pair, either. That is because gtest appears to allocate on heap...

@seladb Updated the PR description, so you might want to reread that. Main update is `New dependency - GoogleTest` under `What's Changed?`

@tigercosmos added `PfRingDeviceList` to the refactor last minute. Sry for the re-review request.

@seladb @clementperon It probably has something to do with `ccache`. Look at #1487. Commit [b13d203](https://github.com/seladb/PcapPlusPlus/pull/1487/commits/b13d203977b4705a10425d8fd6e16595c9151387) passes all checks and then after merge, commit [e418d41](https://github.com/seladb/PcapPlusPlus/pull/1487/commits/e418d41f35cdf80a120f740700e7cec53ed21383) suddenly fails its report with a...

This should be fine since the lists themselves don't have any interconnected dependencies.

Closing as majority is implemented through PRs: #1787 #1790 #1791 #1794 #1795 #1796 #1797